testing: lint and docs improvements #24
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @ccamacho. Thanks for your PR. I'm waiting for a openshift-psap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| print("", file=f) | ||
| print("# Constants", file=f) |
There was a problem hiding this comment.
why did you chose to add # Parameters & # Constants?
(I don't mind, don't remove it)
I'm not 100% sure myself why I chose to put in Python vs in Ansible, but I think it made more sense to have them side by side in the Python code, somehow like a C header files with prototypes and constants
This commit resolves the following lint rules: - 'yaml' - 'yaml[truthy]' - 'risky-file-permissions' - 'no-changed-when' It moves 'yaml' to 'yaml[indentation]' and 'yaml[line-length]' to avoid skipping rules that are needed. Adds an exclusion folder for the .github folder due to ansible/ansible-lint#3645 Updates the toolbox repo 'generate_ansible_default_settings' option to enforce the linting of the parameters and constants.
This commit resolves the following lint rules:
It moves 'yaml' to 'yaml[indentation]' and 'yaml[line-length]' to avoid skipping rules that are needed.
Adds an exclusion folder for the .github folder due to ansible/ansible-lint#3645
Updates the toolbox repo 'generate_ansible_default_settings' option to enforce the linting of the parameters and constants.
Partially solves: #10